admin/40234-vm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: limit client portal data exposure

Browse Source
This commit is contained in:
Flatlogic Bot 2026-06-11 11:44:01 +00:00
parent 84e82223bd
commit 5e6a9a5752
1 changed files with 44 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
backend/src/routes/coaching.js
View File

@ -27,10 +27,33 @@ function isClientUser(req) {
function portalClientIncludes() { function portalClientIncludes() {
return [ return [
{ model: db.sessions, as: "sessions", where: { status: "shared" }, required: false, order: [["session_at", "DESC"]] }, {
{ model: db.action_items, as: "action_items", order: [["due_at", "ASC"]] }, model: db.sessions,
{ model: db.resources, as: "resources", where: { is_shared: true }, required: false }, as: "sessions",
{ model: db.prep_briefs, as: "prep_briefs", order: [["updatedAt", "DESC"]] }, attributes: ["id", "title", "session_at", "status", "shared_client_notes"],
where: { status: "shared" },
required: false,
order: [["session_at", "DESC"]],
},
{
model: db.action_items,
as: "action_items",
attributes: ["id", "title", "due_at", "status"],
order: [["due_at", "ASC"]],
},
{
model: db.resources,
as: "resources",
attributes: ["id", "title", "description", "url", "resource_type", "is_shared"],
where: { is_shared: true },
required: false,
},
{
model: db.prep_briefs,
as: "prep_briefs",
attributes: ["id", "next_session_at", "client_reflection", "client_reflection_at", "status"],
order: [["updatedAt", "DESC"]],
},
]; ];
} }
@ -1007,7 +1030,10 @@ router.get(
return; return;
} }
if (isClientUser(req) && session.client?.email !== req.currentUser.email) { if (
isClientUser(req) &&
(session.status !== "shared" || session.client?.email !== req.currentUser.email)
) {
res.status(404).send({ error: "session_not_found" }); res.status(404).send({ error: "session_not_found" });
return; return;
} }
@ -1315,7 +1341,12 @@ router.patch(
updatedById: req.currentUser.id, updatedById: req.currentUser.id,
}); });
res.status(200).send(actionItem); res.status(200).send({
id: actionItem.id,
title: actionItem.title,
due_at: actionItem.due_at,
status: actionItem.status,
});
}), }),
); );
@ -1379,7 +1410,13 @@ router.post(
}); });
} }
res.status(200).send(prepBrief); res.status(200).send({
id: prepBrief.id,
next_session_at: prepBrief.next_session_at,
client_reflection: prepBrief.client_reflection,
client_reflection_at: prepBrief.client_reflection_at,
status: prepBrief.status,
});
}), }),
); );