From 663b7d98baad4d700fdd2be46df55dfa408669b3 Mon Sep 17 00:00:00 2001 From: Konrad du Plessis Date: Sun, 17 May 2026 06:25:25 +0200 Subject: [PATCH] docs: park 2 Manager/Salaried follow-ups (Spark Receipt payslip verify + monthly_salary display) (3) PENDING: Konrad testing 17 May whether Spark Receipt handles the is_salary payslip layout for variable-pay managers. (4) Deferred: monthly_salary required field is misleading on manager report rows (inert for pay; display-only tidy-up parked). Co-Authored-By: Claude Opus 4.7 (1M context) --- docs/plans/parked-work.md | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/docs/plans/parked-work.md b/docs/plans/parked-work.md index b327bcb..7767bbc 100644 --- a/docs/plans/parked-work.md +++ b/docs/plans/parked-work.md @@ -113,6 +113,38 @@ the 36-commit push `d7015b9..4c25011`. the Manager/Salaried tests cannot perturb it). Low priority: investigate a possible date/locale or response-rendering nondeterminism in that test. **NOT introduced by this feature.** +3. **⏳ PENDING OPERATOR VERIFICATION — Spark Receipt payslip + handling for Salary payments (Konrad testing 17 May 2026).** + Manager/Salaried `Salary` payments email a payslip PDF to Spark + Receipt (`_send_payslip_email`, `SPARK_RECEIPT_EMAIL`) using the + `is_salary` clean single-line layout (no work-log/days table — + mirrors `is_advance`/`is_loan`). Konrad's managers (Konrad, + Christiaan, Fitz) have **variable** monthly pay — there is no fixed + salary; the amount is entered manually per Salary adjustment. + UNKNOWN: whether Spark Receipt's downstream system parses/accepts + this Salary payslip format the same as a normal daily-worker + payslip. Konrad is testing a real Salary payment **later today + (17 May 2026)**. Until confirmed, this is an OPEN external- + integration verification, NOT an in-app defect. If Spark Receipt + mishandles it → follow-up to adjust the `is_salary` payslip + template / email body (`pdf/payslip_pdf.html`, + `email/payslip_email.html`, `core/payslip.html`). +4. **Deferred display tidy-up — `monthly_salary` is misleading for + fixed-pay managers.** `Worker.monthly_salary` is a required field + (no null/blank) but means nothing for variable-pay managers. It is + **inert for their pay/cost** (managers never reach a `WorkLog`, so + `daily_rate` / all WorkLog-derived math never includes them) yet + still **displays** as "monthly salary" + a computed "daily rate" + on the worker detail page, worker batch report, and CSV/PDF + exports — authoritative-looking but meaningless numbers on manager + rows. Pragmatic interim: enter a representative figure (or 0) for + managers. Optional future tidy-up (small, display-only, no pay/cost + impact): hide/relabel the monthly-salary field for `pay_type='fixed'` + in `WorkerForm` + `workers/edit.html`, and suppress/relabel the + monthly/daily columns for managers in `workers/detail.html`, + `workers/batch_report.html`, the workers CSV export, and + `pdf/workers_report_pdf.html`. Low priority — flagged by Konrad + 17 May 2026. > Note: the **Site-progress logging — rebuild from scratch** parked > entry above is unaffected by this Manager/Salaried entry (it was