From b40170f220c046e62d6ec219293fa5a8ab5d4e24 Mon Sep 17 00:00:00 2001
From: Flatlogic Bot <support@flatlogic.com>
Date: Sun, 7 Dec 2025 17:27:54 +0000
Subject: [PATCH] Revert to version 403c8e4

---
 teacher_timetable.php | 83 ++++++++++++++++++-------------------------
 timetable.php         |  8 +----
 2 files changed, 35 insertions(+), 56 deletions(-)

diff --git a/teacher_timetable.php b/teacher_timetable.php
index a7be905..d86497a 100644
--- a/teacher_timetable.php
+++ b/teacher_timetable.php
@@ -103,24 +103,26 @@ foreach ($teacher_schedule_raw as $lesson) {
     $day_idx = $lesson['day_of_week'];
     if (isset($timeslot_id_to_period_idx[$lesson['timeslot_id']])) {
         $period_idx = $timeslot_id_to_period_idx[$lesson['timeslot_id']];
-
-        // Skip if this slot is already filled by a continuation marker
-        if (isset($teacher_timetable_by_period[$day_idx][$period_idx]) && isset($teacher_timetable_by_period[$day_idx][$period_idx]['continuation'])) {
-            continue;
-        }
-
-        // Place the lesson. Handle co-teaching by making it an array.
-        if (!isset($teacher_timetable_by_period[$day_idx][$period_idx]) || $teacher_timetable_by_period[$day_idx][$period_idx] === null) {
-            $teacher_timetable_by_period[$day_idx][$period_idx] = [$lesson];
-        } else {
+        
+        if (isset($teacher_timetable_by_period[$day_idx][$period_idx])) {
+            // This slot is already filled, potentially by a multi-class elective.
+            // Create an array if it's not already one.
+            if (!is_array($teacher_timetable_by_period[$day_idx][$period_idx])) {
+                $teacher_timetable_by_period[$day_idx][$period_idx] = [$teacher_timetable_by_period[$day_idx][$period_idx]];
+            }
             $teacher_timetable_by_period[$day_idx][$period_idx][] = $lesson;
+        } else {
+            $teacher_timetable_by_period[$day_idx][$period_idx] = $lesson;
         }
 
-        if (!empty($lesson['is_double'])) {
-            $next_period_idx = $period_idx + 1;
-            if (isset($non_break_periods[$next_period_idx])) {
-                $continuation_marker = ['continuation' => true, 'original_lesson' => $lesson];
-                $teacher_timetable_by_period[$day_idx][$next_period_idx] = $continuation_marker;
+        if (!empty($lesson['is_double']) && isset($teacher_timetable_by_period[$day_idx][$period_idx + 1])) {
+            if (isset($teacher_timetable_by_period[$day_idx][$period_idx + 1])) {
+                 if (!is_array($teacher_timetable_by_period[$day_idx][$period_idx + 1])) {
+                    $teacher_timetable_by_period[$day_idx][$period_idx + 1] = [$teacher_timetable_by_period[$day_idx][$period_idx + 1]];
+                }
+                $teacher_timetable_by_period[$day_idx][$period_idx + 1][] = $lesson;
+            } else {
+                 $teacher_timetable_by_period[$day_idx][$period_idx + 1] = $lesson;
             }
         }
     }
@@ -232,45 +234,28 @@ error_log("Final teacher_timetable_by_period structure: " . print_r($teacher_tim
                                             <small class="text-muted"><?php echo date("g:i A", strtotime($timeslot_info['start_time'])); ?> - <?php echo date("g:i A", strtotime($timeslot_info['end_time'])); ?></small>
                                         </td>
                                         <?php foreach ($days_of_week as $day_idx => $day): ?>
-                                            <?php
-                                                $lessons = $teacher_timetable_by_period[$day_idx][$period_idx] ?? null;
-
-                                                if (isset($lessons['continuation'])) {
-                                                    // This is a continuation of a double lesson, so we skip rendering the cell.
-                                                } else {
-                                                    $rowspan = 1;
-                                                    // Check if any lesson in this slot is a double lesson
-                                                    if (is_array($lessons)) {
-                                                        foreach ($lessons as $l) {
-                                                            if (!empty($l['is_double'])) {
-                                                                $rowspan = 2;
-                                                                break;
+                                            <td class="timetable-slot align-middle">
+                                                <?php
+                                                $lesson = $teacher_timetable_by_period[$day_idx][$period_idx] ?? null;
+                                                if ($lesson) {
+                                                    // If it's an array of lessons (co-teaching), display them all
+                                                    $lessons_to_display = is_array($lesson) && !isset($lesson['id']) ? $lesson : [$lesson];
+                                                    foreach ($lessons_to_display as $single_lesson) {
+                                                        if ($single_lesson) { // Check not null
+                                                            $display_name = $single_lesson['lesson_display_name'];
+                                                            // For electives, the teacher should see their specific subject.
+                                                            if (!empty($single_lesson['is_elective']) && !empty($single_lesson['subject_name'])) {
+                                                                $display_name = $single_lesson['subject_name'];
                                                             }
+                                                            echo '<div class="lesson p-1 mb-1">';
+                                                            echo '<strong>' . htmlspecialchars($display_name) . '</strong><br>';
+                                                            echo '<small>' . htmlspecialchars($single_lesson['class_name']) . '</small>';
+                                                            echo '</div>';
                                                         }
                                                     }
-                                                ?>
-                                                    <td class="timetable-slot align-middle" rowspan="<?php echo $rowspan; ?>">
-                                                        <?php
-                                                        if (is_array($lessons)) {
-                                                            foreach ($lessons as $single_lesson) {
-                                                                if ($single_lesson) { // Check not null
-                                                                    $display_name = $single_lesson['lesson_display_name'];
-                                                                    // For electives, the teacher should see their specific subject.
-                                                                    if (!empty($single_lesson['is_elective']) && !empty($single_lesson['subject_name'])) {
-                                                                        $display_name = $single_lesson['subject_name'];
-                                                                    }
-                                                                    echo '<div class="lesson p-1 mb-1">';
-                                                                    echo '<strong>' . htmlspecialchars($display_name) . '</strong><br>';
-                                                                    echo '<small>' . htmlspecialchars($single_lesson['class_name']) . '</small>';
-                                                                    echo '</div>';
-                                                                }
-                                                            }
-                                                        }
-                                                        ?>
-                                                    </td>
-                                                <?php
                                                 }
                                                 ?>
+                                            </td>
                                         <?php endforeach; ?>
                                     </tr>
                                 <?php
diff --git a/timetable.php b/timetable.php
index 621729c..6b1a5d6 100644
--- a/timetable.php
+++ b/timetable.php
@@ -464,13 +464,7 @@ function get_timetable_from_db($pdo, $classes, $timeslots, $days_of_week) {
 
         $class_timetables[$class_id][$day_idx][$period_idx] = $lesson_data;
         if ($lesson_data['is_double'] && isset($class_timetables[$class_id][$day_idx][$period_idx + 1])) {
-            // For the second part of a double lesson, create a new array
-            // that is marked as a continuation, but does NOT have is_double = true.
-            // This prevents the rendering logic from trying to start a new rowspan.
-            $continuation_data = $lesson_data;
-            $continuation_data['is_double'] = false;
-            $continuation_data['is_continuation'] = true;
-            $class_timetables[$class_id][$day_idx][$period_idx + 1] = $continuation_data;
+            $class_timetables[$class_id][$day_idx][$period_idx + 1] = $lesson_data;
         }
     }